On 9 December 2011 11:32, Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > On Fri, Dec 09, 2011 at 10:55:10AM +0530, Thomas Abraham wrote: >> On 9 December 2011 10:11, Mark Brown > >> > Removing irq_base from platform data isn't going to be helpful for >> > anyone using the driver on non-DT platforms as it's going to make it >> > impossible to find the interrupts. > >> All the consumers of the max8997 interrupts are the drivers for the >> sub-blocks of max8997. These drivers have access to 'irq_domain' >> member of 'struct max8997_dev', From irq_domain, the sub-block driver >> can get the irq_base and add one of the 'enum max8997_irq' offset when >> registering for interrupt notifications. > > There's no GPIOs with interrupt support (even if they're not implemented > yet)? Ok. There does seem to be 12 gpios supported by max8997, but not used on the origen board. If these gpio's are connected to the host system, and host system sets up gpio interrupt notification for these gpio lines, the linux irq number for the gpio interrupt would belong to the irq domain of the host interrupt controller (gic irq domain in case of exynos). Consumers of this interrupt would use the gpio interrupt independent of the max8997 irq domain. So irq_base can be maintained private to the max8997 mfd driver and its sub-block drivers. Thanks, Thomas. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |