Hi Kukjin, On Tue, Nov 15, 2011 at 12:39 PM, Kukjin Kim <kgene.kim@xxxxxxxxxxx> wrote: > padma venkat wrote: > >> Hi Mark, >> On Fri, Nov 4, 2011 at 4:27 PM, Mark Brown > <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: >> On Fri, Nov 04, 2011 at 08:43:54AM -0400, Padmavathi Venna wrote: >> >> > +#ifdef CONFIG_S3C64XX_DEV_SPI0 >> > +static struct s3c64xx_spi_info crag6410_spi0_pdata __initdata = { >> > + .cfg_gpio = s3c64xx_spi0_cfg_gpio, >> > + .fifo_lvl_mask = 0x7f, >> > + .rx_lvl_offset = 13, >> > + .tx_st_done = 21, >> > +}; >> > +#endif >> It seems like a step backwards to have all this stuff in the individual >> machines - most of this (everything except cfg_gpio pretty much) is a >> property of the SoC silicon so should be somewhere central for the SoC. >> I Will move this stuff to SPI setup files and resend the patches. >> Thanks >> Padma > > Hi Padma, > > Please send text-typed e-mail when you reply :) Okey. > > And I agree with Mark, how was going on? I will send the patches by tomorrow. Thanks&Regards Padma > > Thanks. > > Best regards, > Kgene. > -- > Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer, > SW Solution Development Team, Samsung Electronics Co., Ltd. > > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html