On 16 November 2011 16:53, Mark Brown
<broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> On Wed, Nov 16, 2011 at 01:36:40AM +0530, Thomas Abraham wrote:
>
>> +/* Note: The pin group list needs to be further populated */
>> +static unsigned int exynos4210_spi0_pins[] = {
>> + EXYNOS4_GPB(0), EXYNOS4_GPB(1), EXYNOS4_GPB(2), EXYNOS4_GPB(3),
>> +};
>
> Given the large number of SoCs in play here might it not be better to
> arrange things so that the data part can go in the SoC directory, or at
> least in a file separate to the main driver. Otherwise the file is
> going to get enormous but that's mostly going to be data tables.
I share the same concern here and listed a todo in the driver file to
handle this case. As you said, a separate file to hold this data would
be needed until all the samsung platforms switch to using device tree.
>
> Also, I'd expect these pin lists to include information on the function
> number.
>
Yes, the function number is included for all the pins. It is in
'struct samsung_pin_group' with the member name 'func'. The function
number is expected to be same for all the pins in a group (atleast,
that works for exynos4). If pins in a group need different function
numbers, then I modify this.
Thank you Mark for having a look.
Regards,
Thomas.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
