On Wed, Nov 16, 2011 at 01:36:40AM +0530, Thomas Abraham wrote:
> +/* Note: The pin group list needs to be further populated */
> +static unsigned int exynos4210_spi0_pins[] = {
> + EXYNOS4_GPB(0), EXYNOS4_GPB(1), EXYNOS4_GPB(2), EXYNOS4_GPB(3),
> +};
Given the large number of SoCs in play here might it not be better to
arrange things so that the data part can go in the SoC directory, or at
least in a file separate to the main driver. Otherwise the file is
going to get enormous but that's mostly going to be data tables.
Also, I'd expect these pin lists to include information on the function
number.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
