On 10 October 2011 19:04, Will Deacon <will.deacon@xxxxxxx> wrote: > On Mon, Oct 10, 2011 at 01:35:54PM +0100, Thomas Abraham wrote: >> There are no difficulties with the original patch. But that was not >> how Samsung boards have been selecting the low level debug uart port >> number. The proposed patch tried to maintain the old style. >> >> Another point is that Samsung's Exynos4 (and few other SoC's) has a >> fourth UART port as well. Not that it is used as a debug port >> currently, but there is no technical limitation in using that as a >> console port. So that might need 'DEBUG_S3C_UART3' as well. > > Tell you what then: let's stick with the original patch for now and then you > can refactor the Samsung bit in the future if/when you add support for the > fourth UART. Does that sound OK? Yes. That sounds fine. Thanks for having a look at the proposed diff. Regards, Thomas. > > Will > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html