On Mon, Oct 10, 2011 at 12:56:24PM +0100, Thomas Abraham wrote: > Hi Will, Hi Thomas, > > What is your opinion about the following diff instead of the above one? > > > diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug > index 65cf8c6..035f5cd 100644 > --- a/arch/arm/Kconfig.debug > +++ b/arch/arm/Kconfig.debug > @@ -120,6 +120,15 @@ choice > Say Y here if you want the debug print routines to direct > their output to the second serial port on these devices. > > + config DEBUG_SAMSUNG_UART > + bool "Kernel low-level debugging messages via samsung serial port" > + depends on PLAT_SAMSUNG > + help > + Say Y here if you want the debug print routines to direct > + their output to the serial port for Samsung platforms. Choose > + the uart port with the "S3C UART to use for low-level debug" > + config option. > + > endchoice > > config EARLY_PRINTK > @@ -139,7 +148,7 @@ config OC_ETM > kernel code. > > config DEBUG_S3C_UART > - depends on PLAT_SAMSUNG > + depends on DEBUG_SAMSUNG_UART > int "S3C UART to use for low-level debug" > default "0" > help Well, it's smaller so that's always a plus. However, I don't think the extra level of indirection helps (that is, the "Kernel low-level debugging UART") choice should be where the UART is specified, rather than pointing you at another (platform-specific) option). Did your suggestion come purely out of aesthetics or are you running into difficulties with the original patch? Will -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |