Thomas Abraham wrote: > > Hi Grant, > > On 10 October 2011 04:40, Grant Likely <grant.likely@xxxxxxxxxxxx> wrote: > > On Sun, Oct 9, 2011 at 12:35 PM, Thomas Abraham > > <thomas.abraham@xxxxxxxxxx> wrote: > >> Some of the gpio chips of exynos4 are assigned a default gpio config without > >> the exynos4 specific pull up/down callbacks which resulted in incorrect > >> setting of pull up/down configuration. > >> > >> Fix this by adding two new exynos4 specific entries in the array of default > >> configs with set_pull and get_pull callbacks set to exynos4 specific callbacks > >> The new default gpio configs can then be used for exynos4 gpio chips. > >> > >> Signed-off-by: Thomas Abraham <thomas.abraham@xxxxxxxxxx> > > > > Hi Thomas, > > > > Does this need to be merged as a bug fix for v3.1, or is it for v3.2? > > Does it have any dependencies, or can it go in via the gpio/next tree? > > > This patch is a bug fix for the new consolidated samsung gpio driver > that will be merged in v3.2 via Kukjin's tree. The new consolidated > samsung gpio driver is merged only in Kukjin's for-next and not > available in gpio/next. > Hi Grant and Thomas, Yes this should be applied to my tree and I don't know why this has been missed when I worked on gpio/samsung. Sorry for noisy on gpio/samsung :( Anyway, I will apply this for v3.2 and as a note, this commit has been merged into mainline so you don't need to handle in gpio/next. commit id 0bf8fa04e80a562641f687547053f98670f25cf9("gpio/exynos4: Fix incorrect mapping of gpio pull-up macro to register setting") Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html