On Mon, Jul 04, 2011 at 06:42:08PM +0900, Kukjin Kim wrote: > Russell King - ARM Linux wrote: > > > > On Fri, Jul 01, 2011 at 10:03:48AM +0900, Kukjin Kim wrote: > > > Russell thanks. > > > > > > How do you think to add following for handling failure of cpu_suspend? > > > > > > + mov r0, #-1 > > > > No. -1 is not an error code, and I refuse to create functions which > > use an explicit -1 as a return code to indicate failure. > > > I used wrong words, 'handling failure' :( > > Actually, it means handling other case, like early wakeup but we will > address comments from you :) Bear in mind that others may wish to return negative errno codes through this, so if you want to indicate 'no need to resume and restore state' then I guess using a small positive number would be acceptable to distinguish it from a real error. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |