On Fri, Jul 01, 2011 at 10:03:48AM +0900, Kukjin Kim wrote: > Russell thanks. > > How do you think to add following for handling failure of cpu_suspend? > > + mov r0, #-1 No. -1 is not an error code, and I refuse to create functions which use an explicit -1 as a return code to indicate failure. The code is designed so that the called finisher function can return a valid errno value. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html