Hello, On Wednesday, June 15, 2011 10:01 AM Sylwester Nawrocki wrote: (snipped) > > Sorry, I am not quite sure if I understand the problem here. For > > instance, all Samsung SoC's and each instance of i2c device in a SoC, > > use the same con_id for the i2c 'struct clock' instance. The con_id is > > 'i2c'. The i2c driver uses the con_id 'i2c' to lookup the 'struct > > clock' instance and it works for all Samsung SoC's and all instances > > of i2c device in the SoC. > > > > Is your point different than what I understand? Please help. > > I appreciate your efforts in converting all Samsung platforms to clkdev. > > With the above I2C example I was trying to illustrate the additional > level of indirection that is present in case of OMAP clock mappings, > comparing to your implementation. > As long as IP clock names are same among various SoC there is no issue > at all with your clk lookup approach. > But this is already not the case with LCD controller IP. > On S3C series the IP bus clock name is "lcd" while on S5P series it's > "fimd". > There is a common framebuffer driver for S3C and S5P SoCs. > It just does not look right to me to be adding in the driver switch/case > for the clock names. I thought clkdev is meant to resolve such differences. > > Then how it would be possible to map those clocks into single con_id with > your patches? E.g. > > S3C clk | S5P clk | con_id > --------------------------- > "lcd" | "fimd" | "lcd" ? > > I believe there will come more differences like that in the future. Actually the problem is rather theoretical one. AFAIR in the old days the s3c-fb driver initially got merged with 'lcd' clock name for unknown reasons. The documentation always used 'fimd' name, even for S3C case. However, it was easier to rename 'fimd' clock name to 'lcd' in the platform code (for s5pc110 and s5pv210) than to get patches merged to unmaintained framebuffer subsystem to get it renamed to 'fimd' in the driver. Best regards -- Marek Szyprowski Samsung Poland R&D Center -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |