On Wed, Jun 15, 2011 at 10:01:29AM +0200, Sylwester Nawrocki wrote: > With the above I2C example I was trying to illustrate the additional > level of indirection that is present in case of OMAP clock mappings, > comparing to your implementation. > As long as IP clock names are same among various SoC there is no issue > at all with your clk lookup approach. > But this is already not the case with LCD controller IP. > On S3C series the IP bus clock name is "lcd" while on S5P series it's "fimd". > There is a common framebuffer driver for S3C and S5P SoCs. > It just does not look right to me to be adding in the driver switch/case > for the clock names. I thought clkdev is meant to resolve such differences. You are not mistaken. clk_get() takes the device and a connection id to identify the clock _on_ _that_ _device_ to separate individual clock inputs on the _same_ _device_. It does not take a platform specific clock name. The clock API was created long ago to remove this kind of crud from drivers and keep it local to the platforms. The problem is people seem to like this crud. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |