Jamie Iles wrote:
>
> Hi,
>
Hi Jamie,
> On Thu, Mar 10, 2011 at 01:48:22PM +0900, Sangbeom Kim wrote:
> > And Do you mean that Is needed error handling of clk_enable like
> > below?
> >
> > clk_enable(timerclk);
> >
> > if (IS_ERR(timerclk)){
> > clk_put(timerclk)
> > panic("failed to enable timers clock");
> > }
>
> No, clk_enable() returns negative errno on failure, so something like.
>
> if (clk_enable(timerclk))
> panic("failed to enable timerclk");
>
Thanks for your suggestion.
Yeah, would be better...but I'm thinking we _really_ need that.
Because it is used timer clock, so if fails, maybe happened hang :(
> > There is no another clk_enable for timerclk.
>
> I didn't mean for just timerclk, there are several other clk_enable()'s
> for other clks.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
