Re: [PATCH v4 1/3] ARM: S5P: Add s5p_timer support for HRT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Thu, Mar 10, 2011 at 01:48:22PM +0900, Sangbeom Kim wrote:
> And Do you mean that Is needed error handling of clk_enable  like 
> below?
> 
> 	clk_enable(timerclk);
> 
> 	if (IS_ERR(timerclk)){
> 		clk_put(timerclk)
> 		panic("failed to enable timers clock");
> 	}

No, clk_enable() returns negative errno on failure, so something like.

	if (clk_enable(timerclk))
		panic("failed to enable timerclk");

> There is no another clk_enable for timerclk.

I didn't mean for just timerclk, there are several other clk_enable()'s 
for other clks.

Jamie
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux