Kyungmin Park wrote: > > On Thu, Oct 21, 2010 at 9:58 AM, Kukjin Kim <kgene.kim@xxxxxxxxxxx> wrote: > > From: Seungwhan Youn <sw.youn@xxxxxxxxxxx> > > > > This patch adds to enable/disable DMA operation clock on S3C-PL330 > > DMA controller driver. > > The title and description seems to clock gating but actual code is > just enable at probe and disable at remove. > > Can you make it REAL clock gating, enable clock only when using? > This is just to move DMA enable/disable clock into DMA driver(S3C PL330). So it would be better if we could discuss about what you said next time. Basically, I prefer most clocks should be registered as disabled, then if required enable, just should be controlled in each driver. Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |