On Mon, Oct 11, 2010 at 7:47 PM, Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > On Sat, Oct 09, 2010 at 10:52:26AM +0900, Jassi Brar wrote: >> On Fri, Oct 8, 2010 at 6:07 PM, Seungwhan Youn <claude.youn@xxxxxxxxx> wrote: > >> > Now, I'm almost finished 2nd patch for submit except this audio clock >> > setting. For now, I can only think that remove audio clock setting >> > from this machine code, and add audio clock settings in arch later(may >> > be after arch/arm/plat-samsung get EPLL policy as Mr. Kukjin said). > >> > Is this okay? > >> IMO neither of the method is much better than the other. > >> If neither of the maintainers relent, maybe drop the clock setting altogether >> and mark the machine driver 'BROKEN' until the EPLL management is fixed? > > I'm OK with having the code in the driver, I just want something there > that makes it more discoverable that it's there like a config option. > Having the driver log loudly when it reconfigures the EPLL would > probably also cover it. Thanks. Yes, we should print warning upon changing EPLL. Even better would be to have some sane EPLL(clocks in general) management policy in place. Perhaps, after I am done with Samsung ASoC overhaul, I'll take it up if others parameters favor. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |