Hello, On Saturday, October 02, 2010 12:41 PM Kukjin Kim wrote: > Marek Szyprowski wrote: > > > > Add required platform definitions for S6E63M0 LCD controller on Samsung > > Goni board. > > > > Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> > > Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> > > --- > > > > Changes since v2: > > - removed defines for lcd pin names > > > > arch/arm/mach-s5pv210/mach-goni.c | 66 > > +++++++++++++++++++++++++++++++++++++ > > 1 files changed, 66 insertions(+), 0 deletions(-) > > > > diff --git a/arch/arm/mach-s5pv210/mach-goni.c > b/arch/arm/mach-s5pv210/mach- > > goni.c > > index b0ae208..ac6ebab 100644 > > --- a/arch/arm/mach-s5pv210/mach-goni.c > > +++ b/arch/arm/mach-s5pv210/mach-goni.c > > (snip) > > > +static struct lcd_platform_data s6e63m0_platform_data = { > > + .reset = reset_lcd, > > + .power_on = lcd_power_on, > > + .lcd_enabled = 0, > > + .reset_delay = 120, /* 120ms */ > > + .power_on_delay = 25, /* 25ms */ > > + .power_off_delay = 200, /* 200ms */ > > +}; > > + > > +#define LCD_BUS_NUM 3 > > +static struct spi_board_info spi_board_info[] __initdata = { > > + { > > + .modalias = "s6e63m0", > > + .platform_data = &goni_lcd_platform_data, > > Happened following build error. > arch/arm/mach-s5pv210/mach-goni.c:153: error: 'goni_lcd_platform_data' > undeclared here (not in a function) > > should be 's6e63m0_platform_data'?..let me know your preferred name. > Will apply with changing it. goni_lcd_platform_data is ihmo more appropriate. I'm sorry again for a problem, looks that I mixed something up and I've sent a patch before final cleaning. > > + .max_speed_hz = 1200000, > > + .bus_num = LCD_BUS_NUM, > > + .chip_select = 0, > > + .mode = SPI_MODE_3, > > + .controller_data = (void *)S5PV210_MP01(1), /* DISPLAY_CS */ > > + }, > > +}; > > (snip) Best regards -- Marek Szyprowski Samsung Poland R&D Center -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html