On Thu, Aug 19, 2010 at 06:00:01PM +0300, Vasily Khoruzhick wrote: > diff --git a/arch/arm/mach-s3c2410/mach-h1940.c b/arch/arm/mach-s3c2410/mach-h1940.c > index 779b45b..9717790 100644 > --- a/arch/arm/mach-s3c2410/mach-h1940.c > +++ b/arch/arm/mach-s3c2410/mach-h1940.c > @@ -42,6 +42,7 @@ > #include <mach/regs-gpio.h> > #include <mach/gpio-fns.h> > #include <mach/gpio-nrs.h> > +#include <mach/gpio.h> linux/gpio.h ? > > #include <mach/h1940.h> > #include <mach/h1940-latch.h> > @@ -58,6 +59,16 @@ > #include <plat/mci.h> > #include <plat/ts.h> > > +#ifndef __ASSEMBLY__ > +#define H1940_LATCH ((void __force __iomem *)0xF8000000) > +#else > +#define H1940_LATCH 0xF8000000 > +#endif This file can never be built by the assembler, so the above is pointless. > + > +#define H1940_PA_LATCH (S3C2410_CS2) Parents not required. Rest looks fine to me. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html