Dne Út 24. srpna 2010 16:50:36 Vasily Khoruzhick napsal(a): > В сообщении от 24 августа 2010 17:40:21 автор Marek Vasut написал: > > Defining S3C2410_GPH_GPIONAME for each bit might be better then. > > Well, that requires massive refactoring of h1940 (and rx1950) support. And > btw, that's common for s3c24xx-based machines to use generic s3c24xx gpio > names, not machine specific. I assume I see how it works now. Ok, please put a comment around it then so others will understand what it does. Using machine-specific GPIO names might help readability btw. -- the approach "everyone does it this way so I'll do it this way without thinking" is bad :) Well, it's just my suggestion for improvement of the overall code quality. Ben, what's your opinion? Cheers > > Regards > Vasily -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |