On Thu, Aug 19, 2010 at 7:04 PM, MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx> wrote: > On Wed, Aug 18, 2010 at 11:01 PM, Kukjin Kim <kgene.kim@xxxxxxxxxxx> wrote: >> From: Jongpill Lee <boyko.lee@xxxxxxxxxxx> >> >> This patch adds video clocks for S5PV310/S5PC210. >> >> Signed-off-by: Jongpill Lee <boyko.lee@xxxxxxxxxxx> >> Signed-off-by: Kukjin Kim <kgene.kim@xxxxxxxxxxx> >> --- >> arch/arm/mach-s5pv310/clock.c | 74 +++++++++++++++++++++++++++++++++++++++++ >> 1 files changed, 74 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm/mach-s5pv310/clock.c b/arch/arm/mach-s5pv310/clock.c >> index 14c9707..04bde94 100644 >> --- a/arch/arm/mach-s5pv310/clock.c >> +++ b/arch/arm/mach-s5pv310/clock.c >> @@ -506,6 +506,78 @@ static struct clksrc_sources clkset_group = { >> .nr_sources = ARRAY_SIZE(clkset_group_list), >> }; >> >> +static struct clksrc_clk clk_sclk_mipidphy4l = { >> + .clk = { >> + .name = "sclk_mipidphy4l", >> + .id = -1, >> + .enable = s5pv310_clk_ip_lcd0_ctrl, >> + .ctrlbit = (1 << 4), >> + }, >> + .sources = &clkset_group, >> + .reg_src = { .reg = S5P_CLKSRC_LCD0, .shift = 12, .size = 4 }, >> + .reg_div = { .reg = S5P_CLKDIV_LCD0, .shift = 16, .size = 4 }, >> +}; > > It appears that clk_ip_lcd0[4](CLK_SMMUFIMD0) is not for this clock > source. This SCLK_MIPIDPHY4L seems to be masked by > CLK_SRC_MASK_LCD0[12] (MIPI0_MASK) Um... As CLK_SRC_MASK_LCD0[12] (MIPI0_MASK) controls MUX_MIPI0, it masks both SCLK_MIPIDPHY4L and SCLK_MIPI0. Then, it seems that we cannot mask SCLK_MIPIDPHY4L and SCLK_MIPI0 independently. Then, what about not adding .enable entry for both "sclk_mipidphy4l" and "sclk_mipi" (which is added in the PATCH 14/14)? Affecting another clock source with one does not look good. > >> + >> +static struct clksrc_clk clk_sclk_mipidphy2l = { >> + .clk = { >> + .name = "sclk_mipidphy2l", >> + .id = -1, >> + .enable = s5pv310_clk_ip_lcd1_ctrl, >> + .ctrlbit = (1 << 4), >> + }, >> + .sources = &clkset_group, >> + .reg_src = { .reg = S5P_CLKSRC_LCD1, .shift = 12, .size = 4 }, >> + .reg_div = { .reg = S5P_CLKDIV_LCD1, .shift = 16, .size = 4 }, >> +}; > > Appears to have the similar issue with the previous clock source Same with above. > >> + >> +static struct clk *clkset_mout_g2d0_list[] = { >> + [0] = &clk_mout_mpll.clk, >> + [1] = &clk_sclk_apll.clk, >> +}; >> + >> +static struct clksrc_sources clkset_mout_g2d0 = { >> + .sources = clkset_mout_g2d0_list, >> + .nr_sources = ARRAY_SIZE(clkset_mout_g2d0_list), >> +}; >> + >> +static struct clksrc_clk clk_mout_g2d0 = { >> + .clk = { >> + .name = "mout_g2d0", >> + .id = -1, >> + }, >> + .sources = &clkset_mout_g2d0, >> + .reg_src = { .reg = S5P_CLKSRC_IMAGE, .shift = 0, .size = 1 }, >> +}; >> + >> +static struct clk *clkset_mout_g2d1_list[] = { >> + [0] = &clk_mout_epll.clk, >> + [1] = &clk_sclk_vpll.clk, >> +}; >> + >> +static struct clksrc_sources clkset_mout_g2d1 = { >> + .sources = clkset_mout_g2d1_list, >> + .nr_sources = ARRAY_SIZE(clkset_mout_g2d1_list), >> +}; >> + >> +static struct clksrc_clk clk_mout_g2d1 = { >> + .clk = { >> + .name = "mout_g2d1", >> + .id = -1, >> + }, >> + .sources = &clkset_mout_g2d1, >> + .reg_src = { .reg = S5P_CLKSRC_IMAGE, .shift = 4, .size = 1 }, >> +}; >> + >> +static struct clk *clkset_mout_g2d_list[] = { >> + [0] = &clk_mout_g2d0.clk, >> + [1] = &clk_mout_g2d1.clk, >> +}; >> + >> +static struct clksrc_sources clkset_mout_g2d = { >> + .sources = clkset_mout_g2d_list, >> + .nr_sources = ARRAY_SIZE(clkset_mout_g2d_list), >> +}; >> + >> static struct clksrc_clk clk_dout_mmc0 = { >> .clk = { >> .name = "dout_mmc0", >> @@ -672,6 +744,8 @@ static struct clksrc_clk *sysclks[] = { >> &clk_aclk_100, >> &clk_aclk_160, >> &clk_aclk_133, >> + &clk_sclk_mipidphy4l, >> + &clk_sclk_mipidphy2l, >> &clk_dout_mmc0, >> &clk_dout_mmc1, >> &clk_dout_mmc2, >> -- >> 1.6.2.5 >> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >> > > > > -- > MyungJoo Ham, Ph.D. > Mobile Software Platform Lab, > Digital Media and Communications (DMC) Business > Samsung Electronics > cell: 82-10-6714-2858 > -- MyungJoo Ham (함명주), Ph.D. Mobile Software Platform Lab, Digital Media and Communications (DMC) Business Samsung Electronics cell: 82-10-6714-2858 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html