On Sat, Jul 17, 2010 at 12:43 PM, Jassi Brar <jassisinghbrar@xxxxxxxxx> wrote: > On Fri, Jul 16, 2010 at 9:22 PM, Kukjin Kim <kgene.kim@xxxxxxxxxxx> wrote: >> MyungJoo Ham wrote: >>> >>> CPUFREQ of S5PV210 uses different APLL settings and we provide >>> such values for CPUFREQ at pll.h. We have been using differently >>> between EVT0 and EVT1 machines. Although this version of kernel >>> assumes that the CPU is EVT1, users may use code for EVT0 later. >>> >>> Note that at 1GHz of ARMCLK, APLL should be 1GHz and for other lower >>> ARMCLK, APLL should be 800MHz. >>> >>> Signed-off-by: MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx> >>> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> >>> --- >>> arch/arm/plat-s5p/include/plat/pll.h | 8 ++++++++ >>> 1 files changed, 8 insertions(+), 0 deletions(-) >>> >>> diff --git a/arch/arm/plat-s5p/include/plat/pll.h >> b/arch/arm/plat-s5p/include/plat/pll.h >>> index 7db3227..3112aba 100644 >>> --- a/arch/arm/plat-s5p/include/plat/pll.h >>> +++ b/arch/arm/plat-s5p/include/plat/pll.h >>> @@ -21,6 +21,14 @@ >>> >>> #include <asm/div64.h> >>> >>> +#ifdef CONFIG_CPU_S5PC110_EVT0_ERRATA >> >> Actually, EVT0 is not real chip and not for mass production. >> So don't use in here. > > That was my point in a thread few days ago when I suggested we > be careful while pushing code upstream. > Rather than flood mainline Samsung support with any hardware > we can get our hands on, we need to strategically select > SoCs (& their versions) and machines so that we have maximum > overlap of features and, equally important, _users_ of that code. > That will help us concentrate our efforts on support needed by most > of the users and devices. That's point of view from chip vendor. but in my side we made a product using all chips from evt0, evt1, and fused evt1. Some product used the evt0 chip already. I don't say LSI need to support early chip. you focus on the your selected SoC. The remaining will be done by us. Thank you, Kyungmin Park > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |