On 12.02.25 20:35, Joe Damato wrote:
> On Wed, Feb 12, 2025 at 05:36:59PM +0100, Alexandra Winter wrote:
>> Like other drivers qeth is calling local_bh_enable() after napi_schedule()
>> to kick-start softirqs [0].
>> Since netif_napi_add_tx() and napi_enable() now take the netdev_lock()
>> mutex [1], move them out from under the BH protection. Same solution as in
>> commit a60558644e20 ("wifi: mt76: move napi_enable() from under BH")
>>
>> Fixes: 1b23cdbd2bbc ("net: protect netdev->napi_list with netdev_lock()")
> Hm, I wonder if the fixes should be for commit 413f0271f396 ("net:
> protect NAPI enablement with netdev_lock()") instead ?
I was wondering about that too. netif_napi_add_tx() got the lock in
1b23cdbd2bbc and napi_enable() got the lock in 413f0271f396.
I don't think I can have 2 Fixes tags, can I?
(And I don't think it makes sense to split these few lines up into 2 commits)
I chose 1b23cdbd2bbc because it is the earlier one.
