On Wed, Feb 12, 2025 at 05:36:59PM +0100, Alexandra Winter wrote:
> Like other drivers qeth is calling local_bh_enable() after napi_schedule()
> to kick-start softirqs [0].
> Since netif_napi_add_tx() and napi_enable() now take the netdev_lock()
> mutex [1], move them out from under the BH protection. Same solution as in
> commit a60558644e20 ("wifi: mt76: move napi_enable() from under BH")
>
> Fixes: 1b23cdbd2bbc ("net: protect netdev->napi_list with netdev_lock()")
Hm, I wonder if the fixes should be for commit 413f0271f396 ("net:
protect NAPI enablement with netdev_lock()") instead ?
> Link: https://lore.kernel.org/netdev/20240612181900.4d9d18d0@xxxxxxxxxx/ [0]
> Link: https://lore.kernel.org/netdev/20250115035319.559603-1-kuba@xxxxxxxxxx/ [1]
> Signed-off-by: Alexandra Winter <wintera@xxxxxxxxxxxxx>
> ---
> drivers/s390/net/qeth_core_main.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
Other than the above, I briefly scanned the driver source and the
change seems reasonable.
I am not sure whether a different Fixes is needed or not (I'll leave
that to the maintainers to decide), but whether this is fine as is
or is re-posted with a new Fixes tag:
Acked-by: Joe Damato <jdamato@xxxxxxxxxx>
