Re: [PATCH 2/3] s390/smsgiucv_app: Remove function pointer cast

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 17/04/2024 20.24, Nathan Chancellor wrote:
Clang warns (or errors with CONFIG_WERROR) after enabling
-Wcast-function-type-strict by default:

   drivers/s390/net/smsgiucv_app.c:176:26: error: cast from 'void (*)(const void *)' to 'void (*)(struct device *)' converts to incompatible function type [-Werror,-Wcast-function-type-strict]
     176 |         smsg_app_dev->release = (void (*)(struct device *)) kfree;
         |                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   1 error generated.

Add a standalone function to fix the warning properly, which addresses
the root of the warning that these casts are not safe for kCFI.

Signed-off-by: Nathan Chancellor <nathan@xxxxxxxxxx>
---
  drivers/s390/net/smsgiucv_app.c | 7 ++++++-
  1 file changed, 6 insertions(+), 1 deletion(-)

Reviewed-by: Thomas Huth <thuth@xxxxxxxxxx>






[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Kernel Development]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Info]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Linux Media]     [Device Mapper]

  Powered by Linux