On 17/04/2024 20.24, Nathan Chancellor wrote:
Clang warns (or errors with CONFIG_WERROR) after enabling
-Wcast-function-type-strict by default:
drivers/s390/char/vmlogrdr.c:746:18: error: cast from 'void (*)(const void *)' to 'void (*)(struct device *)' converts to incompatible function type [-Werror,-Wcast-function-type-strict]
746 | dev->release = (void (*)(struct device *))kfree;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
Add a standalone function to fix the warning properly, which addresses
the root of the warning that these casts are not safe for kCFI. The
comment is not really relevant after this change, so remove it.
Signed-off-by: Nathan Chancellor <nathan@xxxxxxxxxx>
---
drivers/s390/char/vmlogrdr.c | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
Reviewed-by: Thomas Huth <thuth@xxxxxxxxxx>
