On Wed, May 03, 2023 at 09:48:36AM +0000, Liu, Yi L wrote: > > From: Jason Gunthorpe <jgg@xxxxxxxxxx> > > Sent: Wednesday, May 3, 2023 2:12 AM > > > > On Sat, Apr 29, 2023 at 12:07:24AM +0800, Yi Liu wrote: > > > > The emulated stuff is for mdev only, it should not be confused with > > > > no-iommu > > > > > > hmmm. I guess the confusion is due to the reuse of > > > vfio_iommufd_emulated_bind(). > > > > This is probabl y not a good direction > > I see. But if not reusing, then there may be a few code duplications. > I'm fine to add separate _bind/unbind() functions for noiommu devices > if Alex and you prefer it. I think you will find there is minimal duplication Jason
