On 2023/4/28 20:07, Jason Gunthorpe wrote:
On Fri, Apr 28, 2023 at 02:21:26PM +0800, Yi Liu wrote:
but this patch needs to use vfio_iommufd_emulated_bind() and
vfio_iommufd_emulated_unbind() for the noiommu devices when binding
to iommufd. So needs to check noiommu in the vfio_iommufd_bind()
and vfio_iommu_unbind() as well.
I'm not sure this is strictly necessary, it just needs an access
The emulated stuff is for mdev only, it should not be confused with
no-iommu
hmmm. I guess the confusion is due to the reuse of
vfio_iommufd_emulated_bind().
Eg if you had a no_iommu_access value to store the access it would be
fine and could serve as the 'this is no_iommu' flag
So this no_iommu_access shall be created per iommufd bind, and call the
iommufd_access_create() with iommufd_access_ops. is it? If so, this is
not 100% the same with no_iommu flag as this flag is static after device
registration.
The only purpose of the access at this moment is to get an iommufdctx
id to return to userspace.
yes. and it is the iommufd_access ID to be returned to userspace.
--
Regards,
Yi Liu
