On 11/28/22 12:43, Alexander Gordeev wrote:
> On Mon, Nov 28, 2022 at 12:01:06PM +0530, Anshuman Khandual wrote:
>>>> diff --git a/include/linux/mm.h b/include/linux/mm.h
>>>> index e9e387caffac..5ead9e997510 100644
>>>> --- a/include/linux/mm.h
>>>> +++ b/include/linux/mm.h
>>>> @@ -2403,7 +2403,7 @@ static inline void pgtable_pte_page_dtor(struct page *page)
>>>>
>>>> #if USE_SPLIT_PMD_PTLOCKS
>>>>
>>>> -static struct page *pmd_pgtable_page(pmd_t *pmd)
>>>> +static inline struct page *pmd_pgtable_page(pmd_t *pmd)
>>>> {
>>>> unsigned long mask = ~(PTRS_PER_PMD * sizeof(pmd_t) - 1);
>>>> return virt_to_page((void *)((unsigned long) pmd & mask));
>>>
>>> This chunk does not appear to belong to this patch.
>>
>> Should not this helper be made a 'static inline' before using it else where ?
>
> Probably yes, but it is not kvm s390-specific change.
Right, just that the s390 change here is the first instance where this helper
is being used outside the header, hence kept them together.
>
> I guess, you wanted to make it together or as a follow-up to this one?
> https://lore.kernel.org/all/20221124131641.1523772-1-anshuman.khandual@xxxxxxx/
>
Unless too much trouble, could we just keep it here as proposed.
