On Wed, Oct 19, 2022 at 01:57:41PM -0400, Eric Farman wrote: > On Wed, 2022-10-19 at 14:15 -0300, Jason Gunthorpe wrote: > > On Wed, Oct 19, 2022 at 06:21:34PM +0200, Eric Farman wrote: > > > > > /* > > > * Initialize a vfio_device so it can be registered to vfio core. > > > - * > > > - * Only vfio-ccw driver should call this interface. > > > */ > > > int vfio_init_device(struct vfio_device *device, struct device > > > *dev, > > > const struct vfio_device_ops *ops) > > > @@ -422,7 +420,6 @@ int vfio_init_device(struct vfio_device > > > *device, struct device *dev, > > > ida_free(&vfio.device_ida, device->index); > > > return ret; > > > } > > > -EXPORT_SYMBOL_GPL(vfio_init_device); > > > > Should be made static as well > > Agreed. Only reason I didn't was there's a prototype in > include/linux/vfio.h to satisfy the call to vfio_init_device from > _vfio_alloc_device, and I didn't want to get into moving things around > if I didn't need to. I can do that on top, if you'd like. You can just add a one line forward static declaration at the top of the file in this patch. Jason
