On Thu, 2022-10-20 at 01:07 -0700, Christoph Hellwig wrote: > On Wed, Oct 19, 2022 at 04:44:30PM +0200, Niklas Schnelle wrote: > > if (ret) > > goto err_resource; > > > > + ret = dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(64)); > > Nit: but you could also just replace the call to dma_set_mask abobe with > a call to dma_set_mask_and_coherent. That makes sense, thanks. Will be added for v2. Also obviously this change is only a prerequisite and could be applied separately, the changed coherent mask won't affect use with the existing DMA implementation.
