On Sun, Apr 17, 2022 at 9:53 PM Christoph Hellwig <hch@xxxxxx> wrote: > > The discard_alignment queue limit is named a bit misleading means the > offset into the block device at which the discard granularity starts. > Setting it to the discard granularity as done by raid5 is mostly > harmless but also useless. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Acked-by: Song Liu <song@xxxxxxxxxx> > --- > drivers/md/raid5.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c > index 59f91e392a2ae..39b0afdf40d0a 100644 > --- a/drivers/md/raid5.c > +++ b/drivers/md/raid5.c > @@ -7749,7 +7749,6 @@ static int raid5_run(struct mddev *mddev) > */ > stripe = stripe * PAGE_SIZE; > stripe = roundup_pow_of_two(stripe); > - mddev->queue->limits.discard_alignment = stripe; > mddev->queue->limits.discard_granularity = stripe; > > blk_queue_max_write_zeroes_sectors(mddev->queue, 0); > -- > 2.30.2 >
