On Fri, Apr 15, 2022 at 5:40 PM Namhyung Kim <namhyung@xxxxxxxxxx> wrote: > > Hello, > > This work is a follow-up of Ian's previous one at > https://lore.kernel.org/all/20220412154817.2728324-1-irogers@xxxxxxxxxx/ > > Fixing up more symbol ends as introduced in: > https://lore.kernel.org/lkml/20220317135536.805-1-mpetlan@xxxxxxxxxx/ > > it caused perf annotate to run into memory limits - every symbol holds > all the disassembled code in the annotation, and so making symbols > ends further away dramatically increased memory usage (40MB to >1GB). > > Modify the symbol end fixup logic so that special kernel cases aren't > applied in the common case. > > v3 changes) > * rename is_kernel to is_kallsyms > * move the logic to generic function > * remove arch-specific functions > > Thanks, > Namhyung Thanks Namhyung! The series: Acked-by: Ian Rogers <irogers@xxxxxxxxxx> > Namhyung Kim (3): > perf symbol: Pass is_kallsyms to symbols__fixup_end() > perf symbol: Update symbols__fixup_end() > perf symbol: Remove arch__symbols__fixup_end() > > tools/perf/arch/arm64/util/machine.c | 21 --------------- > tools/perf/arch/powerpc/util/Build | 1 - > tools/perf/arch/powerpc/util/machine.c | 25 ----------------- > tools/perf/arch/s390/util/machine.c | 16 ----------- > tools/perf/util/symbol-elf.c | 2 +- > tools/perf/util/symbol.c | 37 +++++++++++++++++++------- > tools/perf/util/symbol.h | 3 +-- > 7 files changed, 29 insertions(+), 76 deletions(-) > delete mode 100644 tools/perf/arch/powerpc/util/machine.c > > > base-commit: 41204da4c16071be9090940b18f566832d46becc > -- > 2.36.0.rc0.470.gd361397f0d-goog >
