On Mon, 21 Mar 2022 11:18:55 +0100 Nico Boehr <nrb@xxxxxxxxxxxxx> wrote: > Further extend the instruction interception tests for s390x. This series focuses > on SIGP, STSI and TPROT instructions. > > Some instructions such as STSI already had some coverage and the existing tests > were extended to increase coverage. > > The SIGP instruction has coverage, but not for all orders. Orders > STORE_ADTL_STATUS, SET_PREFIX and CONDITIONAL_EMERGENCY didn't > have coverage before and new tests are added. For EMERGENCY_SIGNAL, the existing > test is extended to cover an invalid CPU address. Additionally, new tests are > added for quite a few invalid arguments to SIGP. > > TPROT was used in skrf tests, but only for storage keys, so add tests for the > other uses as well. I like how this series turned out. once the fourth patch is ironed out, I think this would be ready for queuing > > Nico Boehr (9): > s390x: smp: add tests for several invalid SIGP orders > s390x: smp: stop already stopped CPU > s390x: gs: move to new header file > s390x: smp: add test for SIGP_STORE_ADTL_STATUS order > s390x: smp: add tests for SET_PREFIX > s390x: smp: add test for EMERGENCY_SIGNAL with invalid CPU address > s390x: smp: add tests for CONDITIONAL EMERGENCY > s390x: add TPROT tests > s390x: stsi: check zero and ignored bits in r0 and r1 > > lib/s390x/gs.h | 80 ++++++++ > s390x/Makefile | 1 + > s390x/gs.c | 65 +------ > s390x/smp.c | 437 ++++++++++++++++++++++++++++++++++++++++++++ > s390x/stsi.c | 42 ++++- > s390x/tprot.c | 108 +++++++++++ > s390x/unittests.cfg | 9 + > 7 files changed, 668 insertions(+), 74 deletions(-) > create mode 100644 lib/s390x/gs.h > create mode 100644 s390x/tprot.c >
