On Tue, Oct 05, 2021 at 01:30:45PM +0000, Roberto Sassu wrote: > > From: Juergen Gross [mailto:jgross@xxxxxxxx] > > Sent: Tuesday, October 5, 2021 3:25 PM > > On 05.10.21 15:14, Heiko Carstens wrote: > > > On Tue, Oct 05, 2021 at 02:08:36PM +0200, Roberto Sassu wrote: > > >> Fix two problems found in the strrchr() implementation for s390 > > >> architectures: evaluate empty strings (return the string address instead of > > >> NULL, if '\0' is passed as second argument); evaluate the first character > > >> of non-empty strings (the current implementation stops at the second). > > >> > > >> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > > >> Cc: stable@xxxxxxxxxxxxxxx > > >> Reported-by: Heiko Carstens <hca@xxxxxxxxxxxxx> (incorrect behavior with > > empty strings) > > >> Signed-off-by: Roberto Sassu <roberto.sassu@xxxxxxxxxx> > > >> --- > > >> arch/s390/lib/string.c | 15 +++++++-------- > > >> 1 file changed, 7 insertions(+), 8 deletions(-) > > > > > > Applied, thanks! > > > > > > > Really? I just wanted to write a response: len is unsigned (size_t) > > and compared to be >= 0, which sounds like always true. > > Thanks for catching this. Will fix it. I'll fix it. No need to resend.
