Re: [kvm-unit-tests PATCH v7 09/12] s390x: css: msch, enable test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi Connie,

for the next series, I will move more code of the css.c to the css_lib.c to be able to reuse it for other tests.
One of your suggestions IIRC.
So I will not be able to keep your RB until you have a look at the changes.
I will keep the same algorithms but still...

regards,
Pierre

On 2020-06-05 09:37, Pierre Morel wrote:


On 2020-06-04 15:29, Cornelia Huck wrote:
On Thu, 4 Jun 2020 14:46:05 +0200
Pierre Morel <pmorel@xxxxxxxxxxxxx> wrote:

On 2020-05-27 11:42, Cornelia Huck wrote:
On Mon, 18 May 2020 18:07:28 +0200
Pierre Morel <pmorel@xxxxxxxxxxxxx> wrote:
A second step when testing the channel subsystem is to prepare a channel
for use.
This includes:
- Get the current subchannel Information Block (SCHIB) using STSCH
- Update it in memory to set the ENABLE bit
- Tell the CSS that the SCHIB has been modified using MSCH
- Get the SCHIB from the CSS again to verify that the subchannel is
    enabled.
- If the subchannel is not enabled retry a predefined retries count.

This tests the MSCH instruction to enable a channel succesfuly.
This is NOT a routine to really enable the channel, no retry is done,
in case of error, a report is made.

Hm... so you retry if the subchannel is not enabled after cc 0, but you
don't retry if the cc indicates busy/status pending? Makes sense, as we
don't expect the subchannel to be busy, but a more precise note in the
patch description would be good :)

OK, I add something like
"
- If the command succeed but subchannel is not enabled retry a

s/succeed/succeeds/ :)

    predefined retries count.
- If the command fails, report the failure and do not retry, even
    if cc indicates a busy/status as we do not expect this.

"indicates busy/status pending" ?

"

done, thanks,

Pierre


--
Pierre Morel
IBM Lab Boeblingen



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Kernel Development]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Info]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Linux Media]     [Device Mapper]

  Powered by Linux