On 09.02.20 17:03, Thomas Huth wrote: > On 07/02/2020 12.39, Christian Borntraeger wrote: >> From: Janosch Frank <frankja@xxxxxxxxxxxxx> >> >> diag 308 subcode 0 and 1 require KVM and Ultravisor interaction, since >> the cpus have to be set into multiple reset states. >> >> * All cpus need to be stopped >> * The "unshare all" UVC needs to be executed >> * The "perform reset" UVC needs to be executed >> * The cpus need to be reset via the "set cpu state" UVC >> * The issuing cpu needs to set state 5 via "set cpu state" > > Is the patch description still accurate here? The patch seems mostly > about adding two new UVCs, and not really about diag 308 ... ? Yes, this patch seems a bit unordered, I messed that one up. I will keep the UNSHARE_ALL and the KVM_PV_VM_PREP_RESET things as we call both for diag 308 subcode 0 and 1 (kexec and kdump) Everything else belongs in other patches. Will move and improve the patch description. > >> Signed-off-by: Janosch Frank <frankja@xxxxxxxxxxxxx> >> [borntraeger@xxxxxxxxxx: patch merging, splitting, fixing] >> Signed-off-by: Christian Borntraeger <borntraeger@xxxxxxxxxx> >> --- > [...] >> diff --git a/arch/s390/kvm/diag.c b/arch/s390/kvm/diag.c >> index 3fb54ec2cf3e..390830385b9f 100644 >> --- a/arch/s390/kvm/diag.c >> +++ b/arch/s390/kvm/diag.c >> @@ -13,6 +13,7 @@ >> #include <asm/pgalloc.h> >> #include <asm/gmap.h> >> #include <asm/virtio-ccw.h> >> +#include <asm/uv.h> >> #include "kvm-s390.h" >> #include "trace.h" >> #include "trace-s390.h" > > This single change to diag.c looks like it could either be removed, or > the hunk should belong to another patch. > >> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c >> index 4afa44e3d1ed..0be18ac1afb5 100644 >> --- a/arch/s390/kvm/kvm-s390.c >> +++ b/arch/s390/kvm/kvm-s390.c > > Thomas >
