On 2019-11-28 15:36, David Hildenbrand wrote:
On 28.11.19 13:46, Pierre Morel wrote:
Let's define the PSW bits explicitly, it will clarify their
usage.
Signed-off-by: Pierre Morel <pmorel@xxxxxxxxxxxxx>
---
lib/s390x/asm/arch_bits.h | 20 ++++++++++++++++++++
lib/s390x/asm/arch_def.h | 6 ++----
I'm sorry, but I don't really see a reason to move these 4/5 defines to
a separate header. Can you just keep them in arch_def.h and extend?
no because arch_def.h contains C structures and inline.
(none of your other patches touch arch_bits.h - and it is somewhat a
weird name. Where to put something new: arch_def.h or arch_bits.h? I
would have understood "psw.h", but even that, I don't consider necessary)
I can use a name like psw.h or let fall and keep the hexa.
--
Pierre Morel
IBM Lab Boeblingen
