On 04.11.19 15:36, Janosch Frank wrote:
On 11/4/19 3:32 PM, David Hildenbrand wrote:
On 25.10.19 10:24, Janosch Frank wrote:
KSM will not work on secure pages, because when the kernel reads a
secure page, it will be encrypted and hence no two pages will look the
same.
Let's mark the guest pages as unmergeable when we transition to secure
mode.
Patch itself looks good to me, but I do wonder: Is this really needed
when pinning all encrypted pages currently?
Not sure about races between KSM and the pinning/encrypting thread,
similar to paging, though ...
The pinning was added several months after I wrote the patch.
Now that we have it, we really need to have another proper look at the
whole topic.
Thanks for your review :-)
I'd certainly prefer this patch (+some way to mlock) over pinning ;)
You can have
Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>
For this patch, if you end up needing it :)
--
Thanks,
David / dhildenb
