On Thu, 31 Jan 2019, Tony Krowiak wrote: > On 1/30/19 1:32 PM, Sebastian Ott wrote: > > On Wed, 30 Jan 2019, Tony Krowiak wrote: > >> +++ b/drivers/s390/cio/chsc.h > >> @@ -9,6 +9,7 @@ > >> #include <asm/chsc.h> > >> #include <asm/schid.h> > >> #include <asm/qdio.h> > >> +#include <asm/ap.h> > > > > This should be moved to chsc.c > > I can do that, but I'm curious why. You only need to include ap.h because of the ap_bus_cfg_chg definition and you only use that in chsc.c . Other users of chsc.h don't call that function. Regards, Sebastian