On Wed, 30 Jan 2019, Tony Krowiak wrote: > +#if IS_ENABLED(CONFIG_ZCRYPT) > +void ap_bus_cfg_chg(void); > +#else > +#error "no CONFIG_ZCRYPT" ^ I don't think that's the right thing to do here. > +++ b/drivers/s390/cio/chsc.h > @@ -9,6 +9,7 @@ > #include <asm/chsc.h> > #include <asm/schid.h> > #include <asm/qdio.h> > +#include <asm/ap.h> This should be moved to chsc.c > +++ b/drivers/s390/crypto/ap_bus.c > @@ -35,6 +35,7 @@ > #include <linux/mod_devicetable.h> > #include <linux/debugfs.h> > #include <linux/ctype.h> > +#include <asm/crw.h> This is not needed here. > /* > +* A config change has happened, Force an ap bus rescan. > +*/ > +void ap_bus_cfg_chg(void) > +{ > + AP_DBF(DBF_INFO, "%s config change, forcing bus rescan\n", __func__); > + > + ap_bus_force_rescan(); > +} > +EXPORT_SYMBOL(ap_bus_cfg_chg); There is no need for the export symbol - you don't call that function from module code. As an unrelated question, just to be sure: ap_bus.c is compiled as built-in even with ZCRYPT=m, right? Reviewed-by: Sebastian Ott <sebott@xxxxxxxxxxxxx> Regards, Sebastian