From: Ursula Braun <ubraun@xxxxxxxxxxxxx> Date: Fri, 16 Nov 2018 13:36:12 +0100 > v2->v3: > stay with 8-byte alignment for union smcd_cdc_cursor in > patch 4/5 "net/smc: atomic SMCD cursor handling", but get rid of > __packed for struct smcd_cdc_msg This SMC-D message is defined in some standard somewhere, right? So if this __packed removal changes the layout it will break things. I see smc_cdc_msg has the same issue, and it's layout is defined in RFC7609. If the __packed removal doesn't change the layout, you should remove it from smc_cdc_msg too for consistency. This is why I tell people to never use __packed.
