On 09/04/2018 22:08, David Rientjes wrote: > On Mon, 9 Apr 2018, Christoph Hellwig wrote: > >>> -#ifdef __HAVE_ARCH_PTE_SPECIAL >>> +#ifdef CONFIG_ARCH_HAS_PTE_SPECIAL >>> # define HAVE_PTE_SPECIAL 1 >>> #else >>> # define HAVE_PTE_SPECIAL 0 >> >> I'd say kill this odd indirection and just use the >> CONFIG_ARCH_HAS_PTE_SPECIAL symbol directly. >> >> > > Agree, and I think it would be easier to audit/review if patches 1 and 3 > were folded together to see the relationship between the newly added > selects and what #define's it is replacing. Otherwise, looks good! > Ok I will fold the 3 patches and introduce a new one removing HAVE_PTE_SPECIAL. Thanks, Laurent. -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
