On Mon, Feb 12, 2018 at 4:22 PM, Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> wrote: > 2018-02-12 23:53 GMT+09:00 Ulf Magnusson <ulfalizer@xxxxxxxxx>: >> On Mon, Feb 12, 2018 at 3:21 PM, Masahiro Yamada >> <yamada.masahiro@xxxxxxxxxxxxx> wrote: >>> 'syncconfig' in a more proper name >> >> Wonder if --update-config-files-for-build or something would be an >> even better name. > > I want to use a name that ends with 'config' like any other config targets > because: > > - I want use the same name for scripts/kconfig/conf option > and Makefile target to take advantage of 'simple-targets' [1] > > - I want to use pattern rule to descend into scripts/kconfig/ [2] > > > [1] https://github.com/torvalds/linux/blob/v4.16-rc1/scripts/kconfig/Makefile#L84 > [2] https://github.com/torvalds/linux/blob/v4.16-rc1/Makefile#L506 > > > > It would be possible to directly descend into scripts/kconfig/ like follows, > but I do not have a good reason to break the convention. > > include/config/%.conf: $(KCONFIG_CONFIG) include/config/auto.conf.cmd > $(Q)$(MAKE) $(build)=scripts/kconfig update-config-files-for-build > Ah, right, didn't think of that. Thought it might be nice to hint that it's related to the build phase somehow at least. Not that important I guess. --syncconfig is a big improvement already. Cheers, Ulf -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
