Acked-by: Christian Borntraeger <borntraeger@xxxxxxxxxx> On 11/07/2017 04:22 PM, Jason J. Herne wrote: > Because we do not make use of the cda (channel data address) for test, > no-op ccws no address translation takes place. This means cda could > contain a guest address which we do not want to attempt to free. Let's > check the command type and skip cda free when it is not needed. > > For a TIC ccw, ccw->cda points to either a ccw in an existing chain or > it points to a whole new allocated chain. In either case the data will > be freed when the owning chain is freed. > > Signed-off-by: Jason J. Herne <jjherne@xxxxxxxxxxxxxxxxxx> > Reviewed-by: Dong Jia Shi <bjsdjshi@xxxxxxxxxxxxxxxxxx> > Reviewed-by: Pierre Morel <pmorel@xxxxxxxxxxxxxxxxxx> > --- > drivers/s390/cio/vfio_ccw_cp.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/s390/cio/vfio_ccw_cp.c b/drivers/s390/cio/vfio_ccw_cp.c > index 5ccfdc8..325a9f4 100644 > --- a/drivers/s390/cio/vfio_ccw_cp.c > +++ b/drivers/s390/cio/vfio_ccw_cp.c > @@ -329,6 +329,8 @@ static void ccwchain_cda_free(struct ccwchain *chain, int idx) > { > struct ccw1 *ccw = chain->ch_ccw + idx; > > + if (ccw_is_test(ccw) || ccw_is_noop(ccw) || ccw_is_tic(ccw)) > + return; > if (!ccw->count) > return; > -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html