On Fri, 27 Mar 2015, Heiko Carstens wrote: > On Thu, Mar 26, 2015 at 07:24:58PM +0100, Jiri Kosina wrote: > > On Thu, 26 Mar 2015, Jiri Slaby wrote: > > > > > This is a trivial port from kGraft. Module relocations are not > > > supported. > > > > > > Signed-off-by: Jiri Slaby <jslaby@xxxxxxx> > > > --- > > > [v2] return ENOSYS > > > [v3] proper return value from klp_check_compiler_support > > > > Applied to for-4.1/core. > > Hello Jiri, > > while I do appreciate your work on the s390 architecture backend for > livepatching: this should go upstream only via the s390 tree or with > an Ack from Martin or me. Fair enough; I merged it because I was convinced that we have your Ack for the very same patch in our tree for kGraft, but now that I look again, we apparently don't. So sorry for that. What is your standpoint on this one then, please? > That being said, what is the reason why module relocations are not > supported? That's an addon feature that can be added gradually, it's not crucial for basic functionality. Basically: someone has to write the code, but it's useful even without it. > As far as I can tell right now there is only one simple in-kernel test > case available (which is fine). However is the tool chain to generate > additional livepatch modules, available somewhere? If so, where? For the current feature set of livepatching as-is upstream, no tooling is really hard requirement and the patches are to be written by hand (exactly as the one in the samples/ directory). Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
