Am 11.10.2013 14:28, schrieb Will Deacon: > On Fri, Oct 11, 2013 at 01:08:17PM +0100, Richard Weinberger wrote: >> On Fri, Oct 11, 2013 at 1:47 PM, Chen Gang <gang.chen@xxxxxxxxxxx> wrote: >>> In current kernel wide source code, except other architectures, only >>> s390 scsi drivers use atomic_clear_mask(), and arm/arm64 need not >>> support s390 drivers. >>> >>> So remove atomic_clear_mask() from "arm[64]/include/asm/atomic.h". >> >> Is it really worth removing such a primitive? >> If someone needs it later he has to implement it from scratch and >> introduces bugs... > > The version we have (on ARM64 anyway) already has bugs. Given the choice > between fixing code that has no callers and simply removing it, I'd go for > the latter. Yeah, if it's broken and has no real users, send it to hell. :) Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
