On Tue, Aug 27, 2013 at 09:24:56AM -0400, Paul Gortmaker wrote: > On 13-08-26 01:02 AM, Chen Gang wrote: > > The 3 "if (level >=1)" are redundency, only one is enough. > > Maybe. Or maybe it is a copy and paste (vi yyp) error, and it really > was meant to be incremental values in each if statement. > > When you are not sure of what the code was meant to do, you should > ask the maintainers, vs. perhaps risking adding brokenness on top of > more brokenness. > > Paul. > -- The code is correct and I'd like to leave it as it is. The plan was (and still is) to change it from a single open seqfile to one which actually makes use of an iterator, since the output can fill more than a page and I'd like to avoid reallocations and possible high-order allocations which might fail. The single stsi calls are the natural granularity for iteration. -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
