On 13-08-26 01:02 AM, Chen Gang wrote:
> The 3 "if (level >=1)" are redundency, only one is enough.
Maybe. Or maybe it is a copy and paste (vi yyp) error, and it really
was meant to be incremental values in each if statement.
When you are not sure of what the code was meant to do, you should
ask the maintainers, vs. perhaps risking adding brokenness on top of
more brokenness.
Paul.
--
>
> Signed-off-by: Chen Gang <gang.chen@xxxxxxxxxxx>
> ---
> arch/s390/kernel/sysinfo.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/s390/kernel/sysinfo.c b/arch/s390/kernel/sysinfo.c
> index 811f542..e20336c 100644
> --- a/arch/s390/kernel/sysinfo.c
> +++ b/arch/s390/kernel/sysinfo.c
> @@ -224,12 +224,11 @@ static int sysinfo_show(struct seq_file *m, void *v)
> if (!info)
> return 0;
> level = stsi(NULL, 0, 0, 0);
> - if (level >= 1)
> + if (level >= 1) {
> stsi_1_1_1(m, info);
> - if (level >= 1)
> stsi_15_1_x(m, info);
> - if (level >= 1)
> stsi_1_2_2(m, info);
> + }
> if (level >= 2)
> stsi_2_2_2(m, info);
> if (level >= 3)
>
--
To unsubscribe from this list: send the line "unsubscribe linux-s390" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
