On Mon, 2013-05-13 at 23:01 +0100, Ben Hutchings wrote: [...] > This still doesn't fix the s390 build because like most architectures > it has NET_IP_ALIGN == 2. When NET_IP_ALIGN != 0 we cannot achieve > cache line alignment at either the start or end of a scatter buffer, > so there is actually no point in padding the buffers to a multiple of > the cache line size. All we need is 4-byte alignment of the network > header, so do that. [...] I was just thinking about this again. Do we need to care about alignment in a page fragment at all? Won't all the headers be pulled into the header area before being accessed with any instructions that would require alignment? (We aren't using build_skb().) Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
