On Wed, May 15, 2013 at 10:58:59AM -0400, Mikulas Patocka wrote:
> zfcp: Fix spinlock imbalance in zfcp_qdio_sbal_get
>
> Signed-off-by: Mikulas Patocka <mpatocka@xxxxxxxxxx>
>
> ---
> drivers/s390/scsi/zfcp_qdio.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> Index: linux-2.6/drivers/s390/scsi/zfcp_qdio.c
> ===================================================================
> --- linux-2.6.orig/drivers/s390/scsi/zfcp_qdio.c 2013-05-15 16:53:14.000000000 +0200
> +++ linux-2.6/drivers/s390/scsi/zfcp_qdio.c 2013-05-15 16:54:23.000000000 +0200
> @@ -250,8 +250,11 @@ int zfcp_qdio_sbal_get(struct zfcp_qdio
> ret = wait_event_interruptible_timeout(qdio->req_q_wq,
> zfcp_qdio_sbal_check(qdio), 5 * HZ);
>
> - if (!(atomic_read(&qdio->adapter->status) & ZFCP_STATUS_ADAPTER_QDIOUP))
> + if (!(atomic_read(&qdio->adapter->status) & ZFCP_STATUS_ADAPTER_QDIOUP)) {
> + if (ret <= 0)
> + spin_lock_irq(&qdio->req_q_lock);
> return -EIO;
> + }
Looks good to me. However it's Steffen's call.
--
To unsubscribe from this list: send the line "unsubscribe linux-s390" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
