On 11 March 2013 18:10, Stelian Nirlu <steliannirlu@xxxxxxxxx> wrote: > > > On 11 March 2013 13:33, Heiko Carstens <heiko.carstens@xxxxxxxxxx> wrote: >> >> On Sun, Mar 10, 2013 at 04:14:00PM +0200, Pekka Enberg wrote: >> > On Sun, Mar 10, 2013 at 3:13 PM, Stelian Nirlu <steliannirlu@xxxxxxxxx> >> > wrote: >> > > Signed-off-by: Stelian Nirlu <steliannirlu@xxxxxxxxx> >> > > --- >> > > arch/s390/net/bpf_jit_comp.c | 3 +-- >> > > 1 file changed, 1 insertion(+), 2 deletions(-) >> > > >> > > diff --git a/arch/s390/net/bpf_jit_comp.c >> > > b/arch/s390/net/bpf_jit_comp.c >> > > index 0972e91..e645528 100644 >> > > --- a/arch/s390/net/bpf_jit_comp.c >> > > +++ b/arch/s390/net/bpf_jit_comp.c >> > > @@ -747,10 +747,9 @@ void bpf_jit_compile(struct sk_filter *fp) >> > > >> > > if (!bpf_jit_enable) >> > > return; >> > > - addrs = kmalloc(fp->len * sizeof(*addrs), GFP_KERNEL); >> > > + addrs = kzalloc(fp->len * sizeof(*addrs), GFP_KERNEL); >> > >> > kcalloc() might be more appropriate here to protect against integer >> > overflow if "fp->len" is too large. >> >> Stelian, care to send an updated patch which uses kcalloc() >> instead of kzalloc()? >> > > Yes, sure, I will send the updated patch as soon as possible. > > Thank you, > Stelian I've sent the updated patch. Mail subject: [PATCH v2] s390: use kcalloc instead of kmalloc and memset -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
